Add comment to column tooltip if exists #1745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rathboma
reviewed
Nov 8, 2023
| @@ -614,6 +614,11 @@ export default Vue.extend({ | |||
| headerTooltip += ' [Primary Key]' | |||
| } | |||
|
|
|||
| // if column has a comment, add it to the tooltip | |||
| if (column.comment) { | |||
| headerTooltip += `<br/> ${column.comment}` | |||
There was a problem hiding this comment.
This needs to be made HTML safe, but otherwise, love this! So:
headerTooltip += `<br/> ${escapeHtml(column.comment)}`
Once you've made that change I will merge!
|
Pushed already! Haven't thought about sanitizing HTML.
Also tried it with large comments, don't know if it should be truncated but I've actually found it way less intrussive than I thought it would be.
|
rathboma
approved these changes
Nov 22, 2023
|
Amazing, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the column has a comment, display it on the tooltip