initial spreadsheet mode #1747
Merged
initial spreadsheet mode #1747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@azmy60 looks like you'll need to merge master. I've seen you doing more work on the tabulator branch -- how close is this to being 'good enough' to merge? |
|
Super close. I found just a list of small issues for spreadsheet in beekeeper. Most of them are styling so it should be very quick. Also, one more fix from tabulator is that pressing context menu key from keyboard doesn't work. I'll finish all these most likely today. After that, we're good. |
|
After that, should I port my branch to our forked repo https://github.com/beekeeper-studio/tabulator ? And change the package.json? |
- add context menu to row header column making it look more natural: - fix fk-link and row header hover colors - make the colors look a little unsad when selected - more precise header border/box-shadow position - make the key icons black when the columns are selected - align the column filter builder with the table column headers, they kind of look misaligned
|
Finally it's coming... 🥲 🥳 |
rathboma
approved these changes
Nov 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1507
work on selecting data on tables just like in google sheet!
Blocked on olifolkerd/tabulator#4313