SQLite client #1764
Merged
SQLite client #1764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not-night-but
commented
Nov 8, 2023
rathboma
requested changes
Nov 15, 2023
There was a problem hiding this comment.
Awesome work Day! Great stuff. Only minor changes needed:
Let's not use as and just have two methods. Also - remove the stuff you told yourself to remove :-)
You have a bunch of notes about broken or incomplete things. Can they be dealt with or better notes left?
| } | ||
|
|
||
| createDatabaseSQL(): string { | ||
| throw new Error("Method not implemented."); |
There was a problem hiding this comment.
Maybe we need a NotSupportedError that can be handled in a standard way in the UI?
There was a problem hiding this comment.
I think that's a good idea. Would be super useful for the readonly clients as well
rathboma
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1739
This PR refactors the sqlite client to be a proper class 😀
It also simplifies the query execution methods.