replace native dialog with vue modal #1781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rathboma
approved these changes
Nov 29, 2023
| export default Vue.extend({ | ||
| data() { | ||
| return { | ||
| name: Vue.prototype.$confirmModalId, |
There was a problem hiding this comment.
Can you add a comment that we need to get this from the prototype because we need it to call the modal function?
| }, | ||
| methods: { | ||
| beforeOpen(event: any) { | ||
| this.onConfirm = event.params.onConfirm; |
There was a problem hiding this comment.
I don't super like this, but I guess it's fine for the confirm dialog.
| @@ -196,7 +196,7 @@ import QueryRenameForm from '@/components/common/form/QueryRenameForm.vue' | |||
| this.$root.$emit('favoriteClick', item) | |||
| }, | |||
| async remove(favorite) { | |||
| if (window.confirm("Really delete?")) { | |||
| if (await this.$confirm("Really delete?")) { | |||
There was a problem hiding this comment.
great work adapting the API for this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1755