fix: get columns for a table when setting the foreign keys #1784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rathboma
requested changes
Nov 30, 2023
| if (table !== null) { | ||
| if (!schema) { | ||
| tableData = this.tables.find((t: TableOrView) => escapeHtml(t.name) === table) | ||
| } else { |
There was a problem hiding this comment.
You should just add the async await to the getColumns method. Tabulator supports the valuesLookup parameter being a promise. See https://github.com/olifolkerd/tabulator/blob/0675efd4b7532d91415b9b5ac3bd11b602ba57cf/src/js/modules/Edit/List.js#L525
it calls valuesLookup and if the result is a promise, it awaits.
There was a problem hiding this comment.
@wmontgomery if you make this change we can merge this.
There was a problem hiding this comment.
Seeing this now, will be making the change today
… into bugfix/1750_Relations-Tables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1750