Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: edited column name in TableSchema does not change color #1792

Merged
merged 1 commit into from Nov 18, 2023
Merged

fix: edited column name in TableSchema does not change color #1792

merged 1 commit into from Nov 18, 2023

Conversation

azmy60
Copy link
Contributor

@azmy60 azmy60 commented Nov 17, 2023

The name column should change color when it's edited.

Fix #1754

image

@sweep-ai Sweep AI
Copy link
Contributor

sweep-ai bot commented Nov 17, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

@rathboma rathboma merged commit 7ac2da3 into master Nov 18, 2023
4 checks passed
@rathboma rathboma deleted the fix/persistent-bg-column branch November 18, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rathboma rathboma rathboma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: Structure view - editing a column name doesn't turn the cell green
2 participants
@azmy60 @rathboma