Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: TabTableBuilder and VirtualTableList #1799

Merged
merged 3 commits into from Nov 27, 2023
Merged

fix: TabTableBuilder and VirtualTableList #1799

merged 3 commits into from Nov 27, 2023

Conversation

azmy60
Copy link
Contributor

@azmy60 azmy60 commented Nov 23, 2023

bugs from recent PRs:

  • click the + icon to make a new table, then it shows blank screen.
    cause: undefined defaultSchema method in sqlite.ts
  • when the database is empty, creating a new a table does not show the table in the table list, even after refreshing.
    cause: NaN value (zero divided by zero) in VirtualTableList
  • dislocated empty state when database is empty

@azmy60
fix(sidebar): keeps is NaN in table list & mispositioned empty state
c6fd360
@azmy60
fix(sqlite): undefined defaultSchema method
83bd39f 
This affects many components that uses `defaultSchema`. E.g.
SchemaBuilder shows blank screen when opening it.
rathboma
rathboma approved these changes Nov 26, 2023
View reviewed changes
Copy link
Collaborator

@rathboma rathboma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See minor changes - then good to merge.

apps/studio/src/components/sidebar/core/table_list/VirtualTableList.vue Outdated Show resolved Hide resolved
apps/studio/src/lib/db/clients/sqlite.ts Outdated Show resolved Hide resolved
@azmy60 azmy60 merged commit bbeff86 into master Nov 27, 2023
4 checks passed
@azmy60 azmy60 deleted the fix/virtual-table-list branch November 27, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rathboma rathboma rathboma approved these changes

@not-night-but not-night-but Awaiting requested review from not-night-but

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@azmy60 @rathboma