Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using sass is a spiderweb of problems #1873

Merged
merged 4 commits into from Jan 22, 2024
Merged

using sass is a spiderweb of problems #1873

merged 4 commits into from Jan 22, 2024

Conversation

rathboma
Copy link
Collaborator

@rathboma rathboma commented Jan 10, 2024

fix #1874

@azmy60
Copy link
Contributor

azmy60 commented Jan 18, 2024

I think this is good. Some changes I made:

  • I changed the way we import vendor css files a little bit, cause the old one uses ~ in the beginning of the path that doesn't work with the new config.
  • For some reason, some styles we made couldn't override the vendor css after the new config. I went through some basic flows and fixed all that I've seen but obviously I wouldn't say I've covered all the breaking styles.
  • I'd say most of the breaking styles would be the styles that can't override the vendor css.

@rathboma rathboma marked this pull request as ready for review January 22, 2024 00:00
@rathboma rathboma merged commit be5ee18 into master Jan 22, 2024
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

REFACTOR: Move from node-sass to sass
2 participants