New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Encapsulate codemirror #1907
Encapsulate codemirror #1907
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great start, but we're still 'leaking' too much of codemirror into the parent components. More of that work needs pushing down into text-editor.
Also, while I know we do this in a couple of places because it is unavoidable, we should not call methods directly on child components.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really really good. I think this simplifies the codebase a lot.
That said, this PR still does some things that aren't really in the spirit of how Vue
expects components to communicate with each other (editorInterface).
If we can remove editorInterface I think we'll be good to merge.
@rathboma I removed the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic work here. This was a LOT of refactoring.
@azmy60 Just need to resolve the merge conflicts, then merge away |
fix #1883