New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Postgres inherited client #1909
Conversation
@azmy60 I'll have you review the PostgreSQL version of this. Once it's finished, and you've reviewed it, tag @not-night-but so they can merge it! |
@not-night-but how's this going? It's looking pretty complete aside from failing tests. Need help on the tests, or are you all good? |
@rathboma it is mostly done! The tests should be fine once I get some of azmy's changes in from the MySQL PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff! Just a couple of fixes before we can merge this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
No description provided.