Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copying single row resulting in object object fixed #1936

Merged
merged 3 commits into from Feb 7, 2024

Conversation

therealrinku
Copy link
Contributor

fixes: #1920

@azmy60
Copy link
Contributor

azmy60 commented Feb 4, 2024

@therealrinku This is great! Thanks for submitting the PR! :) Would you mind taking a look if this also happens with the other formats? (JSON/TSV/etc.)

@therealrinku
Copy link
Contributor Author

therealrinku commented Feb 4, 2024

@azmy60 sure, I just checked and turns out there is same issue with TSV and Markdown as well.
I will push some changes for that too 😄

@therealrinku
Copy link
Contributor Author

@azmy60 I was looking into fixing the same for tsv and markdown as well.
I'm thinking about maybe converting all the values from options.range.getData() to string before going to switch statement.

Let me know what do you think about that or if you have any other ideas on how to handle this better ?

@azmy60
Copy link
Contributor

azmy60 commented Feb 5, 2024

Yep. I think that sounds good! :)

Copy link
Contributor

@azmy60 azmy60 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@therealrinku This is awesome! Love the test! I also added a little change to your PR so we could prevent regression issues. :)

@azmy60 azmy60 merged commit 0dd3d64 into beekeeper-studio:master Feb 7, 2024
4 checks passed
@therealrinku therealrinku deleted the fix/copy-json-fix branch February 19, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Copying JSON result in [object Object]
2 participants