Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add row as array flag to sqlite executeQuery #1981

Merged
merged 4 commits into from Mar 8, 2024
Merged

add row as array flag to sqlite executeQuery #1981

merged 4 commits into from Mar 8, 2024

Conversation

azmy60
Copy link
Contributor

@azmy60 azmy60 commented Feb 26, 2024

fix #1978, fix #1976

rathboma
rathboma requested changes Mar 6, 2024
View reviewed changes
Copy link
Collaborator

@rathboma rathboma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have a new integration test to make sure queries that return duplicate column names work right!

@azmy60
Copy link
Contributor Author

azmy60 commented Mar 7, 2024 •
edited

Doesn't queryTests cover the duplicate columns? I removed the filter in queryTests so sqlite can run that.

@rathboma
Copy link
Collaborator

rathboma commented Mar 7, 2024

Oh, does it? If so then good to merge

@azmy60 azmy60 merged commit 56f2347 into master Mar 8, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rathboma rathboma rathboma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@azmy60 @rathboma