Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix focusing text editor each time opening the query tab #1998

Merged
merged 1 commit into from Mar 6, 2024
Merged

fix focusing text editor each time opening the query tab #1998

merged 1 commit into from Mar 6, 2024

Conversation

azmy60
Copy link
Contributor

@azmy60 azmy60 commented Mar 4, 2024 •
edited

Focusing a new tab and a previous tab should focus the text editor.

ref #1994

fixing number 1 and 2

  • Opening a new tab doesn't focus the codemirror editor
  • Switching to an editor tab doesn't focus codemirror unless it has previously been focused

rathboma
rathboma approved these changes Mar 6, 2024
View reviewed changes
Copy link
Collaborator

@rathboma rathboma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should at some point figure out what is stealing the focus

@rathboma rathboma merged commit 874b29c into master Mar 6, 2024
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rathboma rathboma rathboma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@azmy60 @rathboma