fix mssql autocomplete #2045
Merged
fix mssql autocomplete #2045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also another autocomplete fix for SQL Server, that should be put together with #2044 but I'm not sure if this would cause regressions or not, so here's a separate PR.
This should fix #1985 and it's a bug that has been happening from all the way back to bks version 3.4.1, or even way before it.
So what happens is that the dialect we use for SQL Server
text/x-mssqlin codemirror kind of mess up with thegetToken()method. Instead of returning.columnName, it returnscolumnNamewithout dot.Changing it to
text/x-sqlshould work but I'm not sure if it can cause regressions yet.