Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated selector in rainbow-selection-flux/styles/rainbow-selection-flux.atom-text-editor.less #11

Closed
pencilcheck opened this issue Jan 16, 2017 · 3 comments

Comments

@pencilcheck
Copy link

In rainbow-selection-flux/styles/rainbow-selection-flux.atom-text-editor.less:

Starting from Atom v1.13.0, the contents of atom-text-editor elements are no longer encapsulated within a shadow DOM boundary. This means you should stop using :host and ::shadow pseudo-selectors, and prepend all your syntax selectors with syntax--. To prevent breakage with existing style sheets, Atom will automatically upgrade the following selectors:

  • :host::shadow .selection .region => atom-text-editor.editor .selection .region

  • :host .selection .region => atom-text-editor .selection .region

Automatic translation of selectors will be removed in a few release cycles to minimize startup time. Please, make sure to upgrade the above selectors as soon as possible.

@mhulse
Copy link
Collaborator

mhulse commented Jan 16, 2017

Thanks for this info @pencilcheck; I'll make a PR this weekend hopefully. 👍

@mhulse
Copy link
Collaborator

mhulse commented Jan 20, 2017

From Atom itself:

screenshot 2017-01-20 14 30 42

@mhulse
Copy link
Collaborator

mhulse commented Feb 4, 2017

Fixed via PR #13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants