Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#7: Add pyprojec.toml #8

Merged
merged 2 commits into from
Feb 6, 2024
Merged

#7: Add pyprojec.toml #8

merged 2 commits into from
Feb 6, 2024

Conversation

greenw0lf
Copy link
Collaborator

@greenw0lf greenw0lf commented Feb 1, 2024

Linked to issue #7

  • Added pyproject.toml which includes all the base dependencies as seen in dane-example-worker + faster-whisper
  • Generated a poetry.lock file after configuring Poetry locally

The way I generated the files is:

  1. Set up WSL
  2. Set up a virtual environment within WSL and activate it
  3. In the virtual environment, I followed the steps to install pipx
  4. Using pipx, I installed Poetry
  5. Clone the repository and navigate to it within WSL with the venv activated
  6. Run
    poetry init
    And use the same versioning for the base dependencies as in the dane-example-worker
  7. I created the poetry.lock file by running
    poetry install
  8. Finally, for adding faster-whisper, I did
    poetry add faster-whisper

Writing all this down in hopes of process documentation

@greenw0lf greenw0lf added the enhancement New feature or request label Feb 1, 2024
@greenw0lf greenw0lf self-assigned this Feb 1, 2024
@greenw0lf greenw0lf changed the title Preliminary pyproject.toml #7: Add pyprojec.toml Feb 1, 2024
Copy link
Member

@Veldhoen Veldhoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I also like how you documented your w.o.w. in the PR - let's point Kathleen and Marta to this.

Please add formatting (Black) and Linting (Flake8) config, and optionally type checking (mypy).
You can also configure test setup (pytest) here - or in a separate branch together with other test setup. I'll leave that up to you!

Copy link
Member

@Veldhoen Veldhoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I'll merge it now

@Veldhoen Veldhoen merged commit 11b62c9 into main Feb 6, 2024
@Veldhoen Veldhoen deleted the pyproject branch February 6, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants