Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DUO importer #835

Merged
merged 1 commit into from
Dec 4, 2021
Merged

Add DUO importer #835

merged 1 commit into from
Dec 4, 2021

Conversation

anibyl
Copy link
Contributor

@anibyl anibyl commented Oct 27, 2021

Hey there!

This PR adds DUO Mobile OTP importer.

PS: I added translations in the languages I knew; please let me know if it's not the right way of contributing translations.

#68

@anibyl anibyl changed the title Add DUO importer. #68 Add DUO importer Oct 27, 2021
Copy link
Member

@alexbakker alexbakker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! It'll take me a couple of days before I can get my hands on a rooted device again, so I can't test this immediately, but here are some initial comments.

anibyl added a commit to anibyl/Aegis that referenced this pull request Oct 30, 2021
anibyl added a commit to anibyl/Aegis that referenced this pull request Oct 30, 2021
@anibyl
Copy link
Contributor Author

anibyl commented Nov 28, 2021

Hi! How's your search for a rooted device going?

@alexbakker
Copy link
Member

Yes, works well! Could you squash everything into a single commit? I'll merge this afterwards.

@InfiniteCoder06
Copy link
Contributor

Yes, works well! Could you squash everything into a single commit? I'll merge this afterwards.

@alexbakker I think you can squash when merging 🤔?

@alexbakker
Copy link
Member

Yes, but "squash and merge" performs a fast-forward merge instead of creating a merge commit. I'd like to keep things consistent.

@InfiniteCoder06
Copy link
Contributor

Yes, but "squash and merge" performs a fast-forward merge instead of creating a merge commit. I'd like to keep things consistent.

Ohho ok.

@anibyl
Copy link
Contributor Author

anibyl commented Dec 3, 2021

Yes, works well! Could you squash everything into a single commit? I'll merge this afterwards.

Done.

Copy link
Member

@alexbakker alexbakker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alexbakker alexbakker merged commit 5c196f1 into beemdevelopment:master Dec 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants