-
-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DUO importer #835
Add DUO importer #835
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this! It'll take me a couple of days before I can get my hands on a rooted device again, so I can't test this immediately, but here are some initial comments.
app/src/main/java/com/beemdevelopment/aegis/importers/DuoImporter.java
Outdated
Show resolved
Hide resolved
app/src/main/java/com/beemdevelopment/aegis/importers/DuoImporter.java
Outdated
Show resolved
Hide resolved
Hi! How's your search for a rooted device going? |
Yes, works well! Could you squash everything into a single commit? I'll merge this afterwards. |
@alexbakker I think you can squash when merging 🤔? |
Yes, but "squash and merge" performs a fast-forward merge instead of creating a merge commit. I'd like to keep things consistent. |
Ohho ok. |
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Hey there!
This PR adds DUO Mobile OTP importer.
PS: I added translations in the languages I knew; please let me know if it's not the right way of contributing translations.
#68