Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save the database file atomically #26

Closed
alexbakker opened this issue Dec 18, 2018 · 0 comments · Fixed by #306
Closed

Save the database file atomically #26

alexbakker opened this issue Dec 18, 2018 · 0 comments · Fixed by #306
Labels
proposal A proposal for a new feature proposal-accepted An accepted proposal for a new feature

Comments

@alexbakker
Copy link
Member

alexbakker commented Dec 18, 2018 •
edited
Loading

It would be nice to be able to prevent database file corruption in the event that an unexpected shutdown occurs while we're still busy writing the database file to disk. Android has a utility class in its standard library that implements atomic file writes, called AtomicFile.

See also: https://developer.android.com/reference/android/support/v4/util/AtomicFile
@alexbakker alexbakker added the proposal-accepted An accepted proposal for a new feature label Dec 18, 2018
@alexbakker alexbakker added the proposal A proposal for a new feature label Dec 25, 2019
@alexbakker alexbakker mentioned this issue Feb 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
proposal A proposal for a new feature proposal-accepted An accepted proposal for a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Protect writes of the vault file against corruption with AtomicFile alexbakker/Aegis
1 participant
@alexbakker