-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix all compiler warnings #301
Fix all compiler warnings #301
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
BeeSwift/GoalViewController.swift
Outdated
let alertController = UIAlertController(title: "Error", message: "Failed to add datapoint", preferredStyle: .alert) | ||
alertController.addAction(UIAlertAction(title: "OK", style: .cancel)) | ||
self.present(alertController, animated: true) | ||
//UIAlertView(title: "Error", message: "Failed to add datapoint", delegate: nil, cancelButtonTitle: "OK").show() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to commit commented out code
//UIAlertView(title: "Error", message: "Failed to add datapoint", delegate: nil, cancelButtonTitle: "OK").show() |
Ah, yes. The app as is does not support an offline mode. And this Merge Request deals mostly with tackling some 'technical debt'. Previously an alert dialog was shown in the aforementioned scenario. Code was updated to present this dialog in a more modern way. Expected behavior is that the dialog is still shown like it was before (and that that segment of the code compiles without the 'this style of alert dialog is deprecated' warning). Thanks for engagement! |
This addresses the compiler warnings generated while building BeeSwift.
The majority of these are deprecation warnings. The code is updated according to the advice in the warnings. There were also a few changes to building and linking.
Test Plan:
On a single device:
On devices with and without a notch: