Add support for 13.6.4 #32
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The 13.6.4 offsets seem to match all of the previous 13.6.x releases, only the binary hash changes. PR should only need the following (in addition to the README updates): |
|
looks right to me, can we get this merged? |
Did not realize the offsets were the same and only the hash needed to change, fixed.
jetfir3
reviewed
Feb 21, 2024
removed the 13_6_4 and replaced with 13_6
xChickens
approved these changes
Feb 29, 2024
|
Your commit has spaces and not tabs so the lint is failing |
xChickens
suggested changes
Mar 1, 2024
| @@ -238,6 +238,8 @@ var offsets = map[[32]byte]imdOffsetTuple{ | |||
| hexToByte32("fff8db27fef2a2b874f7bc6fb303a98e3e3b8aceb8dd4c5bfa2bad7b76ea438a"): offsets_13_6, | |||
| // macOS 13.6.3 | |||
| hexToByte32("2c674438d30bf489695f2d1b8520afc30cbfb183af82d2fc53d74ce39a25b24e"): offsets_13_6, | |||
| // macOS 13.6.4 | |||
| hexToByte32("8f22dcfda56a4d3c38931f20fe33db1a6720e4d8571e452aa5a8b56b4c69842a"): offsets_13_6, | |||
There was a problem hiding this comment.
Spaced using spaces instead of tabs
|
Duplicate PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add support for users on Ventura 13.6.4.