Issue/79 #14
Merged
Issue/79 #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit allows beer-garden to safely migrate from JSON config files to YAML config files. There is one error case, when moving the files around could cause application startup to fail. I believe this is mostly mitigated because we perform the scary operation last which should throw an error before catastrophic failure occurrs. We also guarantee that the file will be yaml. Since yaml is a superset of JSON, the yaml parser can load JSON just fine in the event that migrating/moving the YAML file does not complete successfully.
hazmat345
suggested changes
Jun 25, 2018
|
Yeah, I didn't realize python2 was broken. I'll fix the tests later. |
|
The python 2.7 tests are failing because of loganasherjones/yapconf#82 I will fix that and release tonight. |
This required an update of yapconf which was not correctly dumping unicode key value pairs.
Codecov Report
@@ Coverage Diff @@
## develop #14 +/- ##
===========================================
+ Coverage 92.34% 92.66% +0.31%
===========================================
Files 9 9
Lines 601 627 +26
===========================================
+ Hits 555 581 +26
Misses 46 46
Continue to review full report at Codecov.
|
hazmat345
approved these changes
Jun 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
You should accept #13 first.
This commit allows beer-garden to safely migrate from JSON config
files to YAML config files. There is one error case, when moving
the files around could cause application startup to fail. I believe
this is mostly mitigated because we perform the scary operation
last which should throw an error before catastrophic failure
occurrs.
We also guarantee that the file will be yaml. Since yaml is a
superset of JSON, the yaml parser can load JSON just fine in
the event that migrating/moving the YAML file does not complete
successfully.