Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using heartbeat instead of deprecated heartbeat_interval #119

Merged
merged 2 commits into from
Feb 24, 2019
Merged

Using heartbeat instead of deprecated heartbeat_interval #119

merged 2 commits into from
Feb 24, 2019

Conversation

hazmat345
Copy link
Contributor

@hazmat345 hazmat345 commented Feb 19, 2019 •
edited

Pika has deprecated a parameter, this PR does the same. Fixes #118

@hazmat345 hazmat345 requested a review from a team February 19, 2019 17:51
loganasherjones
loganasherjones requested changes Feb 22, 2019
View reviewed changes
Copy link
Member

@loganasherjones loganasherjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The heartbeat wasn't introduced until pika 0.11 so if we are going to use it, we need to update the dependency in setup.py to include >0.10

@loganasherjones loganasherjones merged commit c45d98e into develop Feb 24, 2019
@loganasherjones loganasherjones deleted the issue/118 branch February 24, 2019 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loganasherjones loganasherjones loganasherjones approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hazmat345 @loganasherjones