Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding more padding and margin helpers #150

Closed
wants to merge 2 commits into from
Closed

adding more padding and margin helpers #150

wants to merge 2 commits into from

Conversation

FirokOtaku
Copy link
Contributor

Adding completion to padding and margin helpers: .[size]-[padding/margin]-[direction].

Examples: .no-margin-top, .tiny-padding-bottom, .small-margin-left, .padding-right.


Adding a new margin helper: .auto-margin

.auto-margin {
  margin: auto !important;
}

Fixing a probable error of .tiny-margin:

.tiny-margin {
padding: 0.25rem !important;
margin: 0.25rem !important;
}

@beercss beercss deleted the branch beercss:dev May 16, 2023 11:29
@beercss beercss closed this May 16, 2023
@ajusa
Copy link

ajusa commented Aug 9, 2023

Is there a reason for this being closed? I think a padding-left helper would be nice for visually showing indentation. I don't think beercss has a way to visually indent elements at the moment.

@leonardorafael
Copy link
Collaborator

I think the dev branch was deleted and restored. So all the PRs was closed automatically. I believe.

Here we can use the same logic of round helper, because we are trying to maintain the consistency in used names. And stay in the 10kb size too.

I would suggest from {size}-margin-{direction} to {size}-margin {direction}-margin.

// Instead this
<div class="medium-margin-left"></div>
<div class="medium-margin-left medium-margin-right"></div>

<div class="small-margin-left"></div>
<div class="small-margin-left small-margin-right"></div>

<div class="auto-margin-left"></div>
<div class="auto-margin-left auto-margin-right"></div>
// Do this
<div class="left-margin"></div>
<div class="horizontal-margin"></div>

<div class="small-margin left-margin"></div>
<div class="small-margin horizontal-margin"></div>

<div class="auto-margin left-margin"></div>
<div class="auto-margin horizontal-margin"></div>

@leonardorafael leonardorafael mentioned this pull request Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants