Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sensitive values should not be inputs to classes #5

Open
trevor-vaughan opened this issue Mar 12, 2020 · 0 comments · May be fixed by #6
Open

Sensitive values should not be inputs to classes #5

trevor-vaughan opened this issue Mar 12, 2020 · 0 comments · May be fixed by #6

Comments

@trevor-vaughan
Copy link

The current setup means that users cannot pass materials in via Hiera and APL.

trevor-vaughan added a commit to trevor-vaughan/pupmod-beergeek-active_directory that referenced this issue Mar 12, 2020
* Removed the `Sensitive` data type from the class paramters since this
  interferes with APL
* Wrapped the appropriate variables in `Sensitive()` to ensure that they
  were passed to the underlying types safely
* Bumped up the supported version of `stdlib`

Closes beergeek#5
@trevor-vaughan trevor-vaughan linked a pull request Mar 12, 2020 that will close this issue
trevor-vaughan added a commit to trevor-vaughan/pupmod-beergeek-active_directory that referenced this issue Mar 12, 2020
* Removed the `Sensitive` data type from the class paramters since this
  interferes with APL
* Wrapped the appropriate variables in `Sensitive()` to ensure that they
  were passed to the underlying types safely
* Bumped up the supported version of `stdlib`

Closes beergeek#5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant