Add "save" command #127
Merged
Add "save" command #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tatyanaboloban
force-pushed
the
master
branch
from
1bed07a
to
6cef079
Compare
extsoft
requested changes
Nov 14, 2018
There was a problem hiding this comment.
@tatyanaboloban please take a look for the following:
- Squash "Commands list update" and "Add "save" command" commits
- Don't duplicate commit's subject and body in "Add test for 'git elegant save' command"
- "Update README.md" is a bad commit subject. Try to highlight what task it solves.
- The last line in the commit's body has to be a ticket number. See 4613c66 like an example.
docs/README.md
Outdated
| @@ -52,6 +52,9 @@ Shows trailing whitespaces of uncommitted changes. | |||
| ### commands | |||
| Displays all available commands. | |||
|
|
|||
| ### save | |||
| Saves the changes to the current repository as a commit. | |||
There was a problem hiding this comment.
Use branch instead of repository.
src/main/git-elegant-save
Outdated
|
|
||
| default(){ | ||
| boxtee git add --interactive | ||
| boxtee git elegant check --staged |
There was a problem hiding this comment.
Don't use boxtee for git elegant commands.
Suggested change
| boxtee git elegant check --staged | |
| git elegant check --staged |
tatyanaboloban
force-pushed
the
master
branch
from
6cef079
to
7fe5f49
Compare
added 3 commits
November 14, 2018 15:01
Add a description of the "save" command to the README.md bees-hive#113
Add "save" command which saves the changes to the current branch as a commit Add new command "save" to git-elegant-commands bees-hive#113
tatyanaboloban
force-pushed
the
master
branch
from
7fe5f49
to
255e5e3
Compare
extsoft
approved these changes
Nov 15, 2018
|
@rultor please merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#113