Rework git elegant configure command
#132
Conversation
alexbeatnik
commented
May 29, 2019
alexbeatnik
commented
There was a problem hiding this comment.
@alexbeatnik also, you didn't update completions (
). I believe we don't need them anymore.| @@ -23,8 +23,7 @@ _alias_message="add git aliases for all 'elegant git' commands" | |||
|
|
|||
|
|
|||
| _configure() { | |||
| MODE=$1; shift | |||
| FUNCTIONS=$@ | |||
| FUNCTIONS=$@ | |||
There was a problem hiding this comment.
| FUNCTIONS=$@ | |
| FUNCTIONS=$@ |
| --local) _configure --local ${LOCALS[@]} ;; | ||
| *) exit 11 # @todo #9 Add usage message if mandatory argument is not set for `git-elegant configure`. | ||
| esac | ||
|
|
There was a problem hiding this comment.
@alexbeatnik please review empty lines. They don't give any value.
| clean-git | ||
| } | ||
|
|
||
| @test "'configure': '--local' option is available" { |
There was a problem hiding this comment.
@alexbeatnik this option is unavailable. WHy do we have this test?
There was a problem hiding this comment.
@extsoft Thanks for review, fixed
src/main/git-elegant-completion
Outdated
| @@ -18,8 +18,8 @@ _git_elegant() { | |||
| push|epush) | |||
| COMPREPLY=( $(compgen -W "$(git branch | grep \* | cut -d ' ' -f2)" ${cur}) ) | |||
| return 0 ;; | |||
| configure|econfigure) | |||
| COMPREPLY=($(compgen -W '--global --local' -- ${cur}) ) | |||
| configure-repository|econfigure-repository) | |||
There was a problem hiding this comment.
@alexbeatnik we don't need this completion as it's empty. Please remove.
| esac | ||
| } | ||
| _configure _user_name _user_email _core_comment_char _apply_whitespace | ||
| } |
There was a problem hiding this comment.
@alexbeatnik please add an empty line to the end of the file.
There was a problem hiding this comment.
@alexbeatnik could you please search for usage of this command inside the project and replace with a new one? Like
Issue #130 implemented 1. git elegant configure renamed to configure-repository 2. command git configure-repository works like git elegant configure --local 3. Tests and README updated
|
@rultor please merge. |
