Improve configuration experience #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First of all, the configuration logic is described in the documentation. This gives a user more details on what will be configured. Next, the configuration logic is moved to a separate plugin. This allows to reuse it in the future. All tests were updated also. #177
The command allows applying the required configuration to a Git installation. Since there are some interceptionsbetween the `acquire-git` and `acquire-repository`, there are some changes in the overall configuration workflow. These changes are desribed on the documentation. Also, to prevent unexpected tests failures, the `~/.gitconfig` is removed after each test where a real Git repository is used. #177
The configuration will start from `acquire-git` command and guide a user through the process interactively. If standards are configured, they will be printed to CLI instead of reconfiguring. During the installation, `acquire-git` will be executed instead of providing the instructions. This allows updating settings for the new versions automatically. Now, the `read` addon supports partial mocking of the answers correctly. This works because a replay variable is always set with either provided value or empty value. #177
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The proposed changes appertain to #177.
The contribution:
CONTRIBUTING.md > Committing the changesrulesREADME.md > Hands-on development notes@bees-hive/elegant-git-maintainers, please review.