16.0 mig cooperator worker #528

robinkeunen · 2023-10-10T14:39:42Z

Description

Odoo task (if applicable)

https://gestion.coopiteasy.be/web#id=10786&action=475&active_id=469&model=project.task&view_type=form&menu_id=536

Checklist before approval

Tests are present (or not needed).
Credits/copyright have been changed correctly.
Change log snippet is present.
(If a new module) Moving this to OCA has been considered.

codecov-commenter · 2023-10-12T09:33:15Z

Codecov Report

Merging #528 (7f1a73a) into 16.0-mig-eater (3d7f339) will increase coverage by 1.12%.
The diff coverage is 93.42%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@                Coverage Diff                 @@
##           16.0-mig-eater     #528      +/-   ##
==================================================
+ Coverage           67.58%   68.70%   +1.12%     
==================================================
  Files                  53       60       +7     
  Lines                1672     1748      +76     
  Branches              230      236       +6     
==================================================
+ Hits                 1130     1201      +71     
- Misses                500      502       +2     
- Partials               42       45       +3

Files	Coverage Δ
cooperator_worker/__init__.py	`100.00% <100.00%> (ø)`
cooperator_worker/models/__init__.py	`100.00% <100.00%> (ø)`
cooperator_worker/models/product_template.py	`100.00% <100.00%> (ø)`
cooperator_worker/tests/__init__.py	`100.00% <100.00%> (ø)`
cooperator_worker/tests/test_base.py	`100.00% <100.00%> (ø)`
cooperator_worker/tests/test_workers.py	`100.00% <100.00%> (ø)`
cooperator_worker/models/res_partner.py	`83.33% <83.33%> (ø)`

carmenbianca

Mostly LGTM, some comments.

In the future, it's easier (and standard OCA process) to create a separate migration commit for every version through which you are migrating. You don't need to test every version; the process is a development aid and helps future Git archaeologists figure out why some changes were made.

cooperator_worker/models/res_partner.py

cooperator_worker/tests/test_base.py

carmenbianca · 2023-10-23T15:31:12Z

test-requirements.txt

@@ -0,0 +1 @@
+git+https://github.com/coopiteasy/cooperative@16.0-mig-cooperator-static-test-helpers#subdirectory=setup/cooperator


Make sure to delete this commit before merging.

@carmenbianca are you sure I should remove this commit before merging ? The corresponding PR is still open OCA/cooperative#86

(test-requirements here was updated)

If you want this merged sooner rather than later, it's OK to merge as-is. I didn't realise this wasn't an OCA repo.

It's still not ideal (we have to remember to remove that line again), but it'll do.

robinkeunen · 2023-10-24T10:15:43Z

So if I understand correctly, here, I should do

a 13 commit changing the version
a 14 commit changing the version
a 15 commit adapting the tests
a 16 commit changing the version

Correct ?

[REF] Split beesdoo_emc -> cooperator_worker_configuration [ADD] migration script [UPD] Update cooperator_worker_configuration.pot [REF] split beesdoo_emc -> cooperator_eater_configuration [UPD] Update cooperator_eater_configuration.pot [REF] beesdoo_emc -> cooperator_info_session [UPD] Update cooperator_info_session.pot [REM] auto-install [IMP] cooperator_worker_configuration: add help message on is_worker

auto_install was added during the migration. It is a regression both cooperator and beesdoo_shift modules can be used separatly. Making the link is a choice by the user.

Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>

increment versions of dependent modules after renaming of beesdoo_shift and beesdoo_worker_status.

carmenbianca · 2023-10-25T07:12:23Z

Basically yes @ your question on commits.

robinkeunen · 2023-10-25T08:43:27Z

/ocabot merge nobump

github-grap-bot · 2023-10-25T08:43:32Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-528-by-robinkeunen-bump-nobump, awaiting test results.

github-grap-bot · 2023-10-25T08:49:36Z

Congratulations, your PR was merged at 913f549. Thanks a lot for contributing to beescoop. ❤️

polchampion · 2024-01-23T13:27:31Z

functionaly tested on 16-test-cooperator

Configure on share product whether its owner can work and shop
Partner fields is_worker and can_shop are computed from the share they subscribed to. NOK for can_shop, which is initially true on the partner even when it is false on the share product. However, this existing behaviour is not new to 16, and has been discussed here and the situation would require a change:

As is : As long as a partner who is a cooperator doesn't have a working mode, can_shop remains true.
To be in cooperator_worker : if is_worker is true, can_shop should only depend on the shift status. Else, the partner's can_shop should match the share product. Also, is the share product allows to work, it should also always allow to shop.

@carmenbianca I created an internal task to improve this.

polchampion · 2024-01-23T13:48:07Z

Also @carmenbianca I realise that this module is really a shift module, since it is a glue module that adds shift features to cooperator . Should it be renamed shift_cooperator_worker ?

github-grap-bot added the needs review label Oct 10, 2023

robinkeunen force-pushed the 16.0-mig-cooperator_worker branch 2 times, most recently from 097eea5 to 7f1a73a Compare October 12, 2023 09:29

robinkeunen changed the base branch from 16.0 to 16.0-mig-eater October 12, 2023 09:30

carmenbianca requested changes Oct 23, 2023

View reviewed changes

robinkeunen force-pushed the 16.0-mig-cooperator_worker branch from 7f1a73a to 4c3f945 Compare October 24, 2023 12:29

robinkeunen changed the base branch from 16.0-mig-eater to 16.0 October 24, 2023 12:30

robinkeunen force-pushed the 16.0-mig-cooperator_worker branch from 4c3f945 to 73ede91 Compare October 24, 2023 14:58

victor-champonnois and others added 12 commits October 24, 2023 17:00

[IMP] cooperator_*: translations

54e25ed

[UPD] README.rst

0ebf58d

[UPD] Update cooperator_worker.pot

bd5b72d

[FIX] cooperator_worker: remove auto_install

adcb347

auto_install was added during the migration. It is a regression both cooperator and beesdoo_shift modules can be used separatly. Making the link is a choice by the user.

cooperator_worker 12.0.1.1.0

800ea20

[ADD] cooperator_worker_force

3049cb6

[UPD] Update cooperator_worker.pot

32eee47

cooperator_worker 12.0.2.0.0

e169900

[REF] beesdoo_shift -> shift

bffc974

Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>

[REL] increment versions of dependent modules

b272919

increment versions of dependent modules after renaming of beesdoo_shift and beesdoo_worker_status.

[IMP] cooperator_worker: black, isort, prettier

f53683f

robinkeunen force-pushed the 16.0-mig-cooperator_worker branch 3 times, most recently from 0e7f62b to c1c0ca8 Compare October 24, 2023 15:21

robinkeunen added 2 commits October 24, 2023 17:33

[MIG] cooperator_worker: Migration to 16.0

4b51436

[FIX] test-requirements

eac94d1

robinkeunen force-pushed the 16.0-mig-cooperator_worker branch from 4cc5ec5 to eac94d1 Compare October 24, 2023 15:34

robinkeunen requested a review from carmenbianca October 24, 2023 15:56

carmenbianca approved these changes Oct 25, 2023

View reviewed changes

github-grap-bot added the bot is merging ⏳ label Oct 25, 2023

github-grap-bot merged commit 6b84e3c into 16.0 Oct 25, 2023
2 checks passed

github-grap-bot deleted the 16.0-mig-cooperator_worker branch October 25, 2023 08:49

github-grap-bot added merged 🎉 and removed bot is merging ⏳ labels Oct 25, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

16.0 mig cooperator worker #528

16.0 mig cooperator worker #528

robinkeunen commented Oct 10, 2023 •

edited

Loading

codecov-commenter commented Oct 12, 2023

carmenbianca left a comment

carmenbianca Oct 23, 2023

robinkeunen Oct 24, 2023

carmenbianca Oct 25, 2023

robinkeunen commented Oct 24, 2023

carmenbianca commented Oct 25, 2023

robinkeunen commented Oct 25, 2023

github-grap-bot commented Oct 25, 2023

github-grap-bot commented Oct 25, 2023

polchampion commented Jan 23, 2024 •

edited

Loading

polchampion commented Jan 23, 2024

		@@ -0,0 +1 @@
		git+https://github.com/coopiteasy/cooperative@16.0-mig-cooperator-static-test-helpers#subdirectory=setup/cooperator

16.0 mig cooperator worker #528

16.0 mig cooperator worker #528

Conversation

robinkeunen commented Oct 10, 2023 • edited Loading

Description

Odoo task (if applicable)

Checklist before approval

codecov-commenter commented Oct 12, 2023

Codecov Report

carmenbianca left a comment

Choose a reason for hiding this comment

carmenbianca Oct 23, 2023

Choose a reason for hiding this comment

robinkeunen Oct 24, 2023

Choose a reason for hiding this comment

carmenbianca Oct 25, 2023

Choose a reason for hiding this comment

robinkeunen commented Oct 24, 2023

carmenbianca commented Oct 25, 2023

robinkeunen commented Oct 25, 2023

github-grap-bot commented Oct 25, 2023

github-grap-bot commented Oct 25, 2023

polchampion commented Jan 23, 2024 • edited Loading

polchampion commented Jan 23, 2024

robinkeunen commented Oct 10, 2023 •

edited

Loading

polchampion commented Jan 23, 2024 •

edited

Loading