Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chrome on Android changes series colors in with beta dark mode flag set #179

Closed
ziebelje opened this issue Nov 5, 2019 · 6 comments
Closed

Chrome on Android changes series colors in with beta dark mode flag set #179

ziebelje opened this issue Nov 5, 2019 · 6 comments
Labels
Vendor Waiting for more information from the vendor.

Comments

@ziebelje
Copy link
Member

ziebelje commented Nov 5, 2019

When I turn on dark mode flag in Chrome Android app from:
chrome://flags
Force Dark Mode for Web Contents: Enabled

Beestat seems to change color of some (but not all) graph lines. For example, indoor temperature line blends into the background.
Can it stay a fixed color like the other lines?
@ziebelje ziebelje self-assigned this Nov 5, 2019
@ziebelje
Copy link
Member Author

ziebelje commented Nov 5, 2019

image

@ziebelje
Copy link
Member Author

ziebelje commented Nov 5, 2019

Appears to be Chrome on Android only; dark mode on Windows 10 Chrome is fine.

@ziebelje
Copy link
Member Author

ziebelje commented Nov 5, 2019

https://bugs.chromium.org/p/chromium/issues/detail?id=1021526

@ziebelje ziebelje added the Vendor Waiting for more information from the vendor. label Nov 9, 2019
@ziebelje
Copy link
Member Author

For the record I just pushed out a new version of this chart and the issue persists. Waiting on the Chromium team at this point.

@ziebelje ziebelje reopened this Dec 18, 2019
@ziebelje
Copy link
Member Author

Oops

@ziebelje ziebelje removed their assignment Jan 2, 2020
@ziebelje ziebelje changed the title Chrome Android Dark Mode Changes Series Colors Chrome on Android changes series colors in with beta dark mode flag set Jan 18, 2020
@ziebelje
Copy link
Member Author

Amazingly, this bug was actually fixed. Not sure when to expect this in an official release, but I'll call this one closed for now.

https://bugs.chromium.org/p/chromium/issues/detail?id=1021526#c8
https://chromium-review.googlesource.com/c/chromium/src/+/1893111

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Vendor Waiting for more information from the vendor.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ziebelje