beet modify can't delete flexible attribute

[JOJ0]

$ beet -v mod 'spin!' spin::'Deezer' spotify_list:1  path::'/Deezer/'
user configuration: /Users/jojo/.config/beets/config.yaml
data directory: /Users/jojo/.config/beets
plugin paths: /Users/jojo/git/whatlastgenre/plugin/beets/beetsplug; /Users/jojo/git/mried_beetsplug.orig/beetsplug
lastgenre: Loading canonicalization tree ~/git/home_config/lastgenre_conf/genres-tree.yaml
inline: adding item field disc_and_track
inline: adding item field fmt_onetrack
inline: adding item field fmt_albumtrack
inline: adding item field quality
inline: adding item field fmt_format
inline: adding item field fmt_genre
inline: adding item field monthly
inline: adding album field is_onetrack
inline: adding album field bitrate
inline: adding album field wehave
inline: adding album field wehavefromtotal
inline: adding album field incomplete
inline: adding album field item_data_source
inline: adding album field fmt_genre
Sending event: pluginload
library database: /Users/jojo/.config/beets/jtbeets_gin.db
library directory: /Users/jojo/Music/Techno
Sending event: library_opened
Parsed query: AndQuery([RegexpQuery('spin', re.compile('Deezer'), fast=False), BooleanQuery('spotify_list', 1, fast=False), RegexpQuery('path', re.compile('/Deezer/'), fast=True)])
Parsed sort: NullSort()
Modifying 433 items.
No changes to make.
Sending event: cli_exit

but changing that attribute does work:

beet -v mod spin='' spin::'Deezer' spotify_list:1  path::'/Deezer/'
user configuration: /Users/jojo/.config/beets/config.yaml
data directory: /Users/jojo/.config/beets
plugin paths: /Users/jojo/git/whatlastgenre/plugin/beets/beetsplug; /Users/jojo/git/mried_beetsplug.orig/beetsplug
lastgenre: Loading canonicalization tree ~/git/home_config/lastgenre_conf/genres-tree.yaml
inline: adding item field disc_and_track
inline: adding item field fmt_onetrack
inline: adding item field fmt_albumtrack
inline: adding item field quality
inline: adding item field fmt_format
inline: adding item field fmt_genre
inline: adding item field monthly
inline: adding album field is_onetrack
inline: adding album field bitrate
inline: adding album field wehave
inline: adding album field wehavefromtotal
inline: adding album field incomplete
inline: adding album field item_data_source
inline: adding album field fmt_genre
Sending event: pluginload
library database: /Users/jojo/.config/beets/jtbeets_gin.db
library directory: /Users/jojo/Music/Techno
Sending event: library_opened
Parsed query: AndQuery([RegexpQuery('spin', re.compile('Deezer'), fast=False), BooleanQuery('spotify_list', 1, fast=False), RegexpQuery('path', re.compile('/Deezer/'), fast=True)])
Parsed sort: NullSort()
Modifying 433 items.
&ME, Rampa, Adam Port - Send Return - 10 - Pay To Play (0000/)  [] f:MP3-320kCBR a:22-03/Deezer |Electro
  spin: Deezer ->
47 Soul - Shamstep - 02 - Don't Care Where You From (0000/)  [] f:MP3-320kCBR a:23-10/Deezer |Electro
  spin: Deezer ->
59 Times The Pain - Twenty Percent Of My Hand - 03 - Start The Song (0000/)  [] f:MP3-320kCBR a:23-08/Spotify |Alternative
  spin: Deezer ->
59 Times The Pain - Twenty Percent Of My Hand - 09 - Today Is The Day (0000/)  [] f:MP3-320kCBR a:23-08/Spotify |Alternative
  spin: Deezer ->
59 Times The Pain - Twenty Percent Of My Hand - 10 - When Ends Never Meet (0000/)  [] f:MP3-320kCBR a:23-08/Spotify |Alternative
  spin: Deezer ->
59 Times The Pain - Twenty Percent Of My Hand - 13 - We're Still Around (0000/)  [] f:MP3-320kCBR a:23-08/Spotify |Alternative
  spin: Deezer ->
A Tribe Called Quest - Beats, Rhymes & Life - 07 - 1nce Again (feat. Tammy Lucas) (Radio Version) (0000/)  [] f:MP3-320kCBR a:21-12/Deezer |Rap/Hip Hop
  spin: Deezer ->
...
...

Could that be a shell issue? I'm using zsh

Update: Tried the same with bash. Same result.

[JOJ0]

BTW: Whoever recently implemented that this gets logged:

Parsed query: AndQuery([RegexpQuery('spin', re.compile('Deezer'), fast=False), BooleanQuery('spotify_list', 1, fast=False), RegexpQuery('path', re.compile('/Deezer/'), fast=True)])
Parsed sort: NullSort()

I love it! :-)

[sampsyo]

That would be @wisp3rwind in #4962. 😃 👏

[arsaboo]

Can you remove the quotes and try again - beet -v mod spin!...

[JOJ0]

Can you remove the quotes and try again - beet -v mod spin!...

tried that - same

btw: in bash that would lead to an error because ! has a special meaning

[sampsyo]

That's mysterious! I don't see an immediate answer… a couple of places to start looking to debug this could be to make sure the call to modify_parse_args puts the right stuff in the dels list:

beets/beets/ui/commands.py

Line 2033 in d80d459

query, mods, dels = modify_parse_args(decargs(args))

And then, if so, to confirm that this bit of logic is correctly deleting the field from the model objects:

beets/beets/ui/commands.py

Lines 2005 to 2009 in d80d459

	for field in dels:
	try:
	del obj[field]
	except KeyError:
	pass