Re: issue #1028: "embedart: Resize images only once per album #1036
Conversation
|
Thanks for opening the new PR! It looks like this is making a test fail. That test just runs |
| @@ -161,7 +165,16 @@ def embed_album(album, maxwidth=None, quiet=False): | |||
| for item in album.items(): | |||
| embed_item(item, imagepath, maxwidth, None, | |||
| config['embedart']['compare_threshold'].get(int), | |||
| config['embedart']['ifempty'].get(bool)) | |||
| config['embedart']['ifempty'], asalbum=True) | |||
There was a problem hiding this comment.
Please leave in that .get(bool), which will convert the config view to a boolean.
|
Everything seems to pass now, both locally and on Travis. Likewise, I successfully embedded and extracted a file from several flac files. So, hooray! |
|
LGTM! Thanks! ✨ @kerobaros, I'll mark you as a committer to the repo now, so feel free to push little fixes directly if you like. But please feel free to continue to use PRs if you prefer a code review, of course. 😃 |
Re: issue #1028: "embedart: Resize images only once per album
Added function resize_image. embedart now calls resize_image once in embed_album before it calls embed_item once per track. resize_image is also called in embed_item if embed_item is not being called from embed_album.