New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List of possible albums doesn't get limited anymore in 1.3.8 #1068

Closed
robotanarchy opened this Issue Nov 6, 2014 · 5 comments

Comments

Projects
None yet
2 participants
@robotanarchy
Contributor

robotanarchy commented Nov 6, 2014

I was trying to import the popular track "Survivor - Eye of the Tiger" with beets 1.3.8 (just the single track, not an album). I didn't explicitly run the "single track" mode.

What I expected:
Beets would show me 10 or so albums, I could then select as [T]racks and it would import the track fine. If I wanted to see more albums, I could choose [M]ore or something like that.

What happened:
Nothing for a very long time! I left the PC on (its kind of a server anyway) and looked at it the next day. Beets has listed 556 entries of albums with possible matches! That's why it took so long. The import as [T]racks worked fine then.

Activated plugins: mpdupdate, duplicates, lastgenre, lyrics, embedart, replaygain, importfeeds, fetchart, web, fromfilename, discogs, chroma

@sampsyo

This comment has been minimized.

Show comment
Hide comment
@sampsyo

sampsyo Nov 6, 2014

Member

That's distressing! Thanks for the report.

Can you check whether this is related to one of your plugins (i.e., by disabling plugins temporarily and re-trying the import)? Specifically, I'm most eager to blame chroma, discogs, and fromfilename (in that order).

Member

sampsyo commented Nov 6, 2014

That's distressing! Thanks for the report.

Can you check whether this is related to one of your plugins (i.e., by disabling plugins temporarily and re-trying the import)? Specifically, I'm most eager to blame chroma, discogs, and fromfilename (in that order).

@sampsyo sampsyo added the needinfo label Nov 6, 2014

@robotanarchy

This comment has been minimized.

Show comment
Hide comment
@robotanarchy

robotanarchy Nov 7, 2014

Contributor

Good guess, it was the chroma plugin! When it is disabled, the list gets limited to 5 albums.

However, the [M]ore choice also isn't there. Is this intended?

Contributor

robotanarchy commented Nov 7, 2014

Good guess, it was the chroma plugin! When it is disabled, the list gets limited to 5 albums.

However, the [M]ore choice also isn't there. Is this intended?

@sampsyo

This comment has been minimized.

Show comment
Hide comment
@sampsyo

sampsyo Nov 8, 2014

Member

Okay, good to know! I'm still not exactly sure why the plugin is requesting so many matches—any chance you can share the track you're seeing this with (privately, presumably) so I can reproduce the explosion?

However, the [M]ore choice also isn't there. Is this intended?

That only displays in the single-album case, IIRC. If you're looking at a list, there are no "more".

Member

sampsyo commented Nov 8, 2014

Okay, good to know! I'm still not exactly sure why the plugin is requesting so many matches—any chance you can share the track you're seeing this with (privately, presumably) so I can reproduce the explosion?

However, the [M]ore choice also isn't there. Is this intended?

That only displays in the single-album case, IIRC. If you're looking at a list, there are no "more".

@robotanarchy

This comment has been minimized.

Show comment
Hide comment
@robotanarchy

robotanarchy Nov 8, 2014

Contributor

I've sent you the track as private query in IRC.

Well, it appears to really be on so many albums. There are tons of best of 80s albums, then its the rocky 3 soundtrack, ...

Anyway, for this high number of results, a "show more" choice would really make sense (and the user wouldn't need to wait such a long time).

Contributor

robotanarchy commented Nov 8, 2014

I've sent you the track as private query in IRC.

Well, it appears to really be on so many albums. There are tons of best of 80s albums, then its the rocky 3 soundtrack, ...

Anyway, for this high number of results, a "show more" choice would really make sense (and the user wouldn't need to wait such a long time).

@sampsyo sampsyo closed this in 701ed2d Nov 8, 2014

@sampsyo

This comment has been minimized.

Show comment
Hide comment
@sampsyo

sampsyo Nov 8, 2014

Member

Thanks! It was indeed the popularity that was tripping up chroma. It now limits the matched albums to 5, mostly arbitrarily. This could be better, but it will at least avoid the unintentional Eye of the Tiger DoS.

Member

sampsyo commented Nov 8, 2014

Thanks! It was indeed the popularity that was tripping up chroma. It now limits the matched albums to 5, mostly arbitrarily. This could be better, but it will at least avoid the unintentional Eye of the Tiger DoS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment