Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn user when no files are imported from a directory #1127

Merged
merged 3 commits into from Dec 1, 2014

Conversation

geigerzaehler
Copy link
Collaborator

Fixes #1116.

@sampsyo
Copy link
Member

sampsyo commented Dec 1, 2014

Looks great! I like the refactoring to give the factory more responsibility. Thanks for addressing this.

@sampsyo sampsyo merged commit eb8ccef into beetbox:master Dec 1, 2014
sampsyo added a commit that referenced this pull request Dec 1, 2014
Warn user when no files are imported from a directory
sampsyo added a commit that referenced this pull request Dec 1, 2014
@geigerzaehler geigerzaehler deleted the empty-dir-warning branch December 1, 2014 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Emit an error when there's no music to import
2 participants