ImportAdded support for in-place and link imports #1170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for the `ImportAdded` plugin crashing during in-place imports (beetbox#1107). Add support for the new link imports introduced in Beets 1.3.9. Note that link-imports that preserve file modification times will follow the links and preserve the mtimes on the link targets. The mtimes on the links aren't modified.
| if not (session.config['copy'] or session.config['move'] or | ||
| session.config['link']): | ||
| log.debug(u"In place import detected, recording mtimes from source" | ||
| u"paths") |
There was a problem hiding this comment.
This wrapped string seems to be missing a space at the break.
|
Awesome; thank you! ✨ It looks like something is going wrong in a different couple of tests on Python 2.6, according to Travis—any clues as to why? |
|
I don't know what's wrong with the 2.6 tests. I ran all of them locally without any failures using |
|
OK, thanks for the information. It's possible it's just a fluke. Merging now! Thanks again for your stewardship of ImportAdded. 🎉 |
sampsyo
added a commit
that referenced
this pull request
Dec 28, 2014
ImportAdded support for in-place and link imports
|
You're welcome! Since I created the plugin, I feel a certain responsibility ensure that it keeps working :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for the
ImportAddedplugin crashing during in-place imports (#1107).Add support for the new link imports introduced in Beets 1.3.9.
Note that link-imports that preserve file modification times will follow
the links and preserve the mtimes on the link targets. The mtimes on the
links aren't modified.