lastgenre: adding classical music #1240
Conversation
Add classic genre with its subgenres
Add classical subgenres
Freso
changed the title
| @@ -156,6 +156,31 @@ | |||
| - timba | |||
| - twoubadou | |||
| - zouk | |||
| - classic: | |||
There was a problem hiding this comment.
Wouldn't classical be a better "super genre"? classic sounds a bit odd to me.
There was a problem hiding this comment.
Probably, I am not a native speaker. "classical" (Built by 71,025 people (Used 574,814 times)) seems more popular than "classic" (Built by 26,016 people (Used 115,887 times)) on last.fm.
Changing "classic" to "classical"
| - cantata | ||
| - chamber music: | ||
| - string quartet | ||
| - classic |
There was a problem hiding this comment.
I don't think this should be here at all, TBH. :) This could be classic rock, classic punk, a generic classic, etc. Do people actually use this to tag classical music?
There was a problem hiding this comment.
I've not imported my classical CD's yet, but when I do it would be great to have a Classical genre, and not classic - as you point out, that means something different and is far too vague.
There was a problem hiding this comment.
Well, as it is now, classic is given as a subgenre of classical, so it might be okay. I just think it's a too vague, non-specific term to be useful as a genre tag.
There was a problem hiding this comment.
Oh, I see what you mean. I don't think that's the right place for classic, wouldn't you end up having things like classic rock being tagged as classical by mistake then?
There was a problem hiding this comment.
No, classic rock is listed elsewhere in the genre tree, but the tag is likely to be used for all sorts of things on Last.fm, not just classical music.
Removing "classic"
|
Looks good! I've merged it in now with 61797e7 - thank you! :) |
Pullrequest for this issue: #1239