Updated permissions plugin to change directory permissions too. #1324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| for directory in dir_list] | ||
|
|
||
| # Get rid of duplicates. | ||
| dir_chmod_queue = list(set(dir_chmod_queue)) |
There was a problem hiding this comment.
Any particular reason not to just use a set to begin with?
|
Looks like it's on the right track! I'd love to avoid some of the complexity in |
|
you know what? thank you so much for your comments. im still a beginner and this helps me alot. i will try my best :) |
| """ | ||
| return [ancestor | ||
| for ancestor in ancestry(item) | ||
| if library in ancestor][1:] |
There was a problem hiding this comment.
How about ancestor.startswith(library) for specificity?
|
Looking good! Could you please add a changelog entry? After that (and the tiny thing above), please go ahead and hit the merge button. 😃 ✨ |
…plicates in a list
…and use the ancestors function instead of writing something new.
xsteadfastx
added a commit
that referenced
this pull request
Feb 17, 2015
Updated permissions plugin to change directory permissions too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tried to implement feature request #1308. whats your opinion about it? i added my own way to find the folders to run chmod on. like this it only changes artist and album folders in the beets directory and not on full ancestors.