Use Levenshtein distance from Jellyfish library #1389
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've created a small benchmark where I generated 10 misspellings (using a probabilistic approach) for all the artists / albums / songs in my library (about ~5600 items).
These are the results comparing 3 popular C packages, with our current one
Despite being pretty informal benchmarks, they do show the two orders of magnitude difference.
I've decided to go with
jellyfish
over python-Levenshtein because:In #646 it was brought up to use the package optionally (and fallback on our own implementation if it wasn't installed). I don’t really see a reason for this, considering Jellyfish works everywhere and does this already.
Oh and the refactoring plans mention something about using
difflib.ratio()
, but it is in fact not a Levenshtein distance.