New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use comma as "or" operator for queries #1423
Conversation
Scan the query parts for commas (u',') and treat these as sub-AndQueries that need to be wrapped in an OrQuery (if there are more than 1 of these)
That means that any query holding a comma should now be escaped... I'm not sure how I feel about that. |
Awesome! This looks great to me. As that thread in #976 suggested, a comma seems like the right thing to me. It's not quite true, @brunal, that every comma will need to be escaped—commas are only ORs when they appear by themselves or at the end of a term. So
does not invoke an OR query. I'm inclined to merge this now. We could restrict this to only work with separated commas ( |
@SampSo My original implementation only worked with separated commas, but I found myself constantly typing |
Use comma as "or" operator for queries
OK, merged! We can at least see how people like this design. Thanks again! This will be awesome to have. ✨ |
Awesome! Thanks a lot, @tomjaspers! |
Scan the query parts for commas (
u','
) and treat these as (sub)AndQuery
sthat need to be wrapped in an
OrQuery
(if there are more than one).Supports
foo, bar
andfoo , bar
.See #976