Fix: ignored-list in match section is… ignored. #1487
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-urban
force-pushed
the
fix-match-ignore
branch
2 times, most recently
from
5820740
to
5a854a7
Compare
|
Thanks! |
m-urban
added a commit
to m-urban/beets
that referenced
this pull request
Jun 1, 2015
untitaker
added a commit
that referenced
this pull request
Jun 1, 2015
Updated changelog with information on fix #1487
|
Oops! Nice catch; thanks. |
LordSputnik
pushed a commit
to LordSputnik/beets
that referenced
this pull request
Jul 6, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
I just realized that the
option didn't work for me as described. After looking into the source, I discovered that the list that is used to match ignored parameters, is filled with the
Distanceobject's values instead of its keys. The PR should fix this.