fix auto-grouping #1550
Merged
fix auto-grouping #1550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The auto-grouper only worked if the filenames in the directory happened to already be in order by artist & album. Now, the code will first sort by artist & album, then group them.
|
Looks great; thank you for fixing this! Would you mind fixing the tiny style issue reported by Travis? I think it just wants a space after the comma. And then if you add a quick note to the changelog, we should be ready to merge. |
|
Finally got it to pass the tests! If it's not the spacing, it's that the line's too long :-P I've also added a note in the changelog, so I think this should be good to go. Thanks, |
|
Fantastic! Thank you again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The auto-grouper only worked if the filenames in the directory happened to already be in order by artist & album. Now, the code will first sort by artist & album, then group them.