Fix #1303: process DateItemField tags in YMD order
#1589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks like a good solution. I tried for a little while to cook up a neater sorting mechanism that wouldn't involve interpolating strings, but they all seem way more complicated than this. ✨ Thank you! |
sampsyo
added a commit
that referenced
this pull request
Sep 2, 2015
Fix #1303: process `DateItemField` tags in YMD order
sampsyo
added a commit
that referenced
this pull request
Sep 2, 2015
|
Great, thank you! Cheers, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This should fix bug #1303. Basically, this patch sorts the name of all metadata tags in (a somewhat tweaked) lexicographic order when they are processed by the
MediaFile.update()method.Only instances of
DateItemFieldget sorted in the year < month < day order, so that updates to the correspondingDateFieldobject are done in the proper order. It does so by replacing the substringsyear,month, anddaybydate0,date1, anddate2, respectively, in the field name ofDateItemFieldobjects, so that this new string can be used as a key for the sorting algorithm.There are several other ways to do that, but I think that's the more robust. I'm of course open to discussion. 😃
Cheers,
Jérémie.