Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remove_art_file configuration property to EmbedArt plugin #1591

Merged
merged 6 commits into from Sep 7, 2015

Conversation

jackwilsdon
Copy link
Member

Adds a configuration property for automatically removing album art files after embedding them.

embedart:
  remove_art_file: yes|no

@jackwilsdon jackwilsdon changed the title Add remove_art_file configuration property Add remove_art_file configuration property to EmbedArt plugin Sep 6, 2015
@sampsyo
Copy link
Member

sampsyo commented Sep 6, 2015

This looks great; thank you for the contribution!

Can you please also add a note to the documentation describing the option (and why someone might want to use it)?

@jackwilsdon
Copy link
Member Author

I've improved the description of remove_art_file with a small section on it's purpose (to be used alongside fetchart).

@jackwilsdon
Copy link
Member Author

There seems to be an issue with the fact that album.artpath isn't set back to None, so other plugins (e.g. convert) get confused when the art doesn't exist.

@jackwilsdon
Copy link
Member Author

So I have tried setting album.artpath to None, however it isn't saved. Is there a method I need to call to save the data? Looks like calling album.store() does the trick.

@sampsyo
Copy link
Member

sampsyo commented Sep 7, 2015

So it does! Awesome work; thank you for fixing that last detail. ✨

@sampsyo sampsyo merged commit 64e33b2 into beetbox:master Sep 7, 2015
sampsyo added a commit that referenced this pull request Sep 7, 2015
Add `remove_art_file` configuration property to EmbedArt plugin
sampsyo added a commit that referenced this pull request Sep 7, 2015
jackwilsdon added a commit to jackwilsdon/beets that referenced this pull request Sep 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants