Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add library_name configuration property to PlexUpdate plugin (fixes #1572) #1595

Merged
merged 3 commits into from Sep 10, 2015

Conversation

jackwilsdon
Copy link
Member

Adds a configuration property to allow the use of libraries that are not named Music. This fixes #1572.

plexupdate:
  library_name: Music (new)

@jackwilsdon
Copy link
Member Author

Should there be a test for library_name (maybe pass a name to add_response_get_music_section?) or is it OK to just fix the failing tests (due to changing the signature) and leave it at that?

@jackwilsdon
Copy link
Member Author

Is there a reason you are not using .get() in your tests when retrieving configuration properties? I have to use self.config['plex']['library_name'].get() to get the Unicode value of it, otherwise the comparison fails (comparing a string and a beets.util.confit.Subview).

@sampsyo
Copy link
Member

sampsyo commented Sep 8, 2015

Looks awesome! Thanks! ✨ As always, a test for the new functionality is helpful if it's not too difficult (but don't worry if it looks like more trouble than it's worth). Would you mind adding a changelog entry too?

And yes, it looks like those tests should be using .get(). Seems like a simple oversight.

@jackwilsdon
Copy link
Member Author

Should I create a new PR using .get() for all tests? Or should it be left as-is for now?

I'll add the changelog entry in a moment 😄.

@sampsyo
Copy link
Member

sampsyo commented Sep 8, 2015

Amending this PR will be fine in this case.

@jackwilsdon
Copy link
Member Author

Everything should be sorted now.

@sampsyo
Copy link
Member

sampsyo commented Sep 10, 2015

Awesome! Thanks again!

sampsyo added a commit that referenced this pull request Sep 10, 2015
Add `library_name` configuration property to PlexUpdate plugin (fixes #1572)
@sampsyo sampsyo merged commit c7603fc into beetbox:master Sep 10, 2015
jackwilsdon added a commit to jackwilsdon/beets that referenced this pull request Sep 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

plexupdate: Doesn't work with libaries not named "Music"
3 participants