Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typos in variables, methods & options #1802

Closed
JesseWeinstein opened this issue Jan 6, 2016 · 4 comments
Closed

Typos in variables, methods & options #1802

JesseWeinstein opened this issue Jan 6, 2016 · 4 comments
Labels
bug bugs that are confirmed and actionable

Comments

@JesseWeinstein
Copy link
Contributor

Here are some typos I've noticed:

https://github.com/sampsyo/beets/blob/master/beets/ui/commands.py#L443 def _summary_judment(rec): should be def _summary_judgment(rec):

https://github.com/sampsyo/beets/blob/master/beetsplug/play.py#L44 'warning_treshold': 100, should be 'warning_threshold': 100,

I'll submit a PR to fix them soon.

@sampsyo
Copy link
Member

sampsyo commented Jan 6, 2016

Agh; so embarrassing! Thanks!

@sampsyo sampsyo added the bug bugs that are confirmed and actionable label Jan 6, 2016
@nathdwek
Copy link
Member

nathdwek commented Jan 6, 2016

Yup, I'm the one to blame for the second one. Just let me check if there are more instances of this particular spelling mistake.

E:Ok, I misspelled it systematically.

@nathdwek
Copy link
Member

nathdwek commented Jan 6, 2016

You can base your PR on top of fix-typos

@JesseWeinstein
Copy link
Contributor Author

Yeah, I just saw it. I'd suggest we just support both config keys, for backwards compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs that are confirmed and actionable
Projects
None yet
Development

No branches or pull requests

3 participants