Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edit plugin doesn't rename folders #1804

Closed
stp242 opened this issue Jan 8, 2016 · 10 comments
Closed

edit plugin doesn't rename folders #1804

stp242 opened this issue Jan 8, 2016 · 10 comments
Labels
bug bugs that are confirmed and actionable

Comments

@stp242
Copy link

stp242 commented Jan 8, 2016

when I do:
beet edit album:"somealbum"

and change the album artist, the folder doesn't get renamed.

using beets 1.3.16 on OS X 10.9

@sampsyo
Copy link
Member

sampsyo commented Jan 8, 2016

Thanks! This is indeed a bug. Addressing it now.

@sampsyo sampsyo added the bug bugs that are confirmed and actionable label Jan 8, 2016
@sampsyo sampsyo closed this as completed in 635052e Jan 8, 2016
@sampsyo
Copy link
Member

sampsyo commented Jan 8, 2016

Fix pushed. Would you mind taking a look to see if this fixes it for you?

@stp242
Copy link
Author

stp242 commented Jan 9, 2016

thank you for the quick update

the path still remains the same 😕

@sampsyo
Copy link
Member

sampsyo commented Jan 9, 2016

Can you give a few more details about what's going on? Your configuration and an example showing your modification would help.

@stp242
Copy link
Author

stp242 commented Jan 9, 2016

here's my config: https://gist.github.com/stp242/fb1f07e9a100603aa271

so I do:
beet -v edit album:"fulfilled wish"
output: https://gist.github.com/stp242/83ff078640419660deea

but if I do:
beet -v mod -aw album:"fulfilled wish" year=2007
it gets renamed correctly, output: https://gist.github.com/stp242/f6efced9fa93fa8c13cf

@sampsyo
Copy link
Member

sampsyo commented Jan 9, 2016

As with the modify command, you'll need to use the -a flag when editing album-level fields. Does that help?

@stp242
Copy link
Author

stp242 commented Jan 9, 2016

for some reason I haven't been able to use that option:

beet edit: error: no such option: -a

@sampsyo
Copy link
Member

sampsyo commented Jan 9, 2016

Very strange! This works fine here:

$ beet edit -a
<editor opens>

Any chance you have an older git checkout?

@stp242
Copy link
Author

stp242 commented Jan 10, 2016

I tested it in a virtual machine with linux and now it works 😃
I will try to reinstall pip/python on OS X.

also it looks a lot different inside the editor this time, some fields like label and year are missing. do you know if that's on purpose? it would be great to have them again

thanks a lot for the help 😃

@sampsyo
Copy link
Member

sampsyo commented Jan 10, 2016

Huh! Sounds like you probably had a pre-release version checked out.

It's now possible to configure the set of fields that gets displayed. The docs for the plugin can help you out with that.

@sampsyo sampsyo reopened this Jan 10, 2016
@sampsyo sampsyo closed this as completed Jan 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs that are confirmed and actionable
Projects
None yet
Development

No branches or pull requests

2 participants