Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaygain audiotools backend crashes #1873

Closed
Kraymer opened this issue Feb 7, 2016 · 2 comments
Closed

Replaygain audiotools backend crashes #1873

Kraymer opened this issue Feb 7, 2016 · 2 comments

Comments

@Kraymer
Copy link
Collaborator

Kraymer commented Feb 7, 2016

Decided to give a try to another backend than mp3gain.
Tested with Python Audio Tools 3.1.1 and 2.22.

$ beet replaygain tchigi
Traceback (most recent call last):
  File "/usr/local/bin/beet", line 9, in <module>
    load_entry_point('beets==1.3.16', 'console_scripts', 'beet')()
  File "/usr/local/lib/python2.7/site-packages/beets/ui/__init__.py", line 1207, in main
    _raw_main(args)
  File "/usr/local/lib/python2.7/site-packages/beets/ui/__init__.py", line 1197, in _raw_main
    subcommand.func(lib, suboptions, subargs)
  File "/usr/local/lib/python2.7/site-packages/beetsplug/replaygain.py", line 936, in func
    self.handle_track(item, write)
  File "/usr/local/lib/python2.7/site-packages/beetsplug/replaygain.py", line 898, in handle_track
    track_gains = self.backend_instance.compute_track_gain([item])
  File "/usr/local/lib/python2.7/site-packages/beetsplug/replaygain.py", line 701, in compute_track_gain
    return [self._compute_track_gain(item) for item in items]
  File "/usr/local/lib/python2.7/site-packages/beetsplug/replaygain.py", line 730, in _compute_track_gain
    rg_track_gain, rg_track_peak = rg._title_gain(rg, audiofile)
AttributeError: 'replaygain.ReplayGain' object has no attribute '_title_gain'

I'm wondering if someone is using this backend with success.
@frubino maybe?

@sampsyo sampsyo closed this as completed in 314521b Feb 7, 2016
@sampsyo
Copy link
Member

sampsyo commented Feb 7, 2016

Thanks for trying it out! I didn't test this, but I did notice an obvious typo that caused this error. Maybe give that a try?

@Kraymer
Copy link
Collaborator Author

Kraymer commented Feb 7, 2016

Yep i did notice this typo but did not test it properly , coz it does fix the problem with the 2.22.
And I edit the docs, the bump to 3.x apparently coincide with breaking changes in the API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants