EchoNest API Key Redaction

[nomadturk]

Problem

When you run beet config command, all the api keys except echonest's are redacted.You can see it in cleartext.

Setup

• OS: Debian
• Python version: 2.7.9
• beets version: 1.3.17

[nomadturk]

Also as a side note, the beet config output also displays musicbrains username and password in cleartext as well. I think they should also be redacted for careless copy/pasters.

[sampsyo]

Thanks! I looked into this a little more closely, and I found that my key was getting redacted. The problem, it seems, is that it only gets redacted when the plugin is enabled—because plugins are how beets knows which fields are sensitive.

That's clearly not great, because it means it's possible to accidentally leak your key if you disable a plugin, but at least that explains why it's happening!

Anyway, the MB password thing was indeed just missing altogether; I added the redaction flag for that.