acousticbrainz plugin: Access acousticbrainz.org over HTTPS. #2007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Freso
force-pushed
the
https-acousticbrainz
branch
from
edb4753
to
37b9360
Compare
|
This seems totally fine; I think moving on from the previous LTS of Ubuntu is no big deal for us (who knows what version of beets they have packaged!). As soon as someone has made sure this actually works, it seems fine to merge. |
Freso
added a commit
that referenced
this pull request
May 21, 2016
acousticbrainz plugin: Access acousticbrainz.org over HTTPS. URL: #2007
|
Tested, merged, pushed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AcousticBrainz is going HTTPS-only soon: https://blog.musicbrainz.org/2016/05/19/were-actually-really-going-to-take-the-https-plunge/
This may cause the plugin to not work with Python <2.7.9 though, hence the PR instead of just pushing it into the tree. OTOH, I don't think the AcousticBrainz people are going to wait around for Debian/Ubuntu to update their packages to move along.
Also not sure about the changelog entry.
Also also: not actually tested yet.