Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bs1770gain uses wrong parameters #2031

Closed
pszxzsd opened this issue Jun 1, 2016 · 1 comment · Fixed by #2032
Closed

bs1770gain uses wrong parameters #2031

pszxzsd opened this issue Jun 1, 2016 · 1 comment · Fixed by #2032
Labels
bug bugs that are confirmed and actionable

Comments

@pszxzsd
Copy link
Contributor

pszxzsd commented Jun 1, 2016

Applying replaygain with bs1770gain uses the parameter -it which means get integrated loudness and calculate true peak.

Specifying -i is just superfluous because that's the default anyway and -t is wrong for two reasons:

  1. Replaygain specifies sample peak, not any other fancy peak calculation methods
  2. Calculating true peak is horrrrribly slow, the whole process is like 10x slower with this

Solution: invoke bs1770gain with parameter -p instead to calculate the correct peak gain and get a major speed boost as a bonus.

@sampsyo sampsyo added the bug bugs that are confirmed and actionable label Jun 2, 2016
@sampsyo
Copy link
Member

sampsyo commented Jun 2, 2016

This does look like a bug! I don't know why those were chosen originally, but let's fix them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs that are confirmed and actionable
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants