New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Homebrew's bash-completion2 #2038
Conversation
@@ -1666,6 +1666,7 @@ def print_completion(*args): | |||
u'/usr/share/local/bash-completion/bash_completion', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know you didn't change this @bismark, but this looks like it may be a spelling mistake as I don't know of any systems that have a /usr/share/local
(should be /usr/local/share
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yah, seemed a bit strange to me... It's been around since 74cb897. I'll defer to the maintainers on making any changes. 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@geigerzaehler: Any ideas on if this is a valid path?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoa, weird -- this does look wrong to me. I say this is probably a typo (influenced by the line above, which looks similar but is actually correct) and we should probably drop it in favor of @bismark's new line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reminds me of "The Last Line Effect" haha!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that's exactly it!
Support Homebrew's bash-completion2
bash-completion2 is installed at a different path. This will stop the warning about being unable to find bash-completion.